[Feat/NST-13] group member 화면 구현완료 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thingineeer
approved these changes
Feb 10, 2025
Comment on lines
64
to
69
| .subscribe(onNext: { [weak self] group in | ||
| self?.rootView.groupProfileImageView.image = .imgProfileFilled // api 연결시 변경 | ||
| self?.rootView.groupNameLabel.text = group.name | ||
| self?.rootView.groupMemberTotalLabel.text = "그룹 멤버 \(group.membersCount)" | ||
| self?.rootView.groupMemberLabel.text = "멤버 (\(group.membersCount)/50)" | ||
| }) |
There was a problem hiding this comment.
guard let self = self else { return }
을 활용하는 건 어떤가요~?
oyslucy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Issue
close #34
🔥 PR Point
그룹 멤버 화면을 구현했습니다
폰트 기강도 잡았어요~~~
NSTDateUtility 관련된 내용은 이전 PR과 동일한테 이전에 컨플릭트 해결하면서 반영이 안 된 듯 합니다 ,, 변경사항은 따로 없습니당
다들파이팅 ㅋㅋ
🔥 ScreenShot
🔥 Reference