Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialization of wdust for dust settling #181

Closed
wants to merge 2 commits into from

Conversation

jmaerz
Copy link
Collaborator

@jmaerz jmaerz commented Aug 15, 2022

The settling velocity of 'free' dust wdust seem to have not been properly initialized when running the model without the -D AGG flag. Further, some surface input flux could happen, since wdust, correctly initialized, would always be positive. Hence, I introduced wdustd (similar to wpocd, etc.). This bugfix can affect the sediment budget, thus the burrying and sediment remineralization rates.

… no-flux boundary condition at surface enabled

This bugfix potentially affects the sediment burrying rate
@TomasTorsvik
Copy link
Contributor

We might want to place this bug fix in a new development branch instead of the master branch.

@jmaerz
Copy link
Collaborator Author

jmaerz commented Aug 15, 2022

Yes, we can do so. I just wanted to prepare the fix and make you aware of the issue.

@jmaerz
Copy link
Collaborator Author

jmaerz commented Aug 15, 2022

Argh, I just realized, I was wrong wrt initialization. The issue with the surface flux might be an issue though, which I need to check. Sorry for the confusion.

@jmaerz
Copy link
Collaborator Author

jmaerz commented Aug 15, 2022

I reverted changes related to the initialization. However, the fix for the surface flux of free dust remains, and with that the potential change of sediment-related processes.

@JorgSchwinger
Copy link
Contributor

Thanks for spotting this, looks good. I agree with Tomas that we shouldn't merge this into master right now. We should discuss this very soon, and make a plan for when to start merging answer changing changes (as raised by Tomas in #169).

@jmaerz jmaerz mentioned this pull request Aug 22, 2022
@jmaerz jmaerz closed this Aug 22, 2022
@jmaerz jmaerz deleted the fix_wdust branch November 23, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants