Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NUOPC driver #199

Merged
merged 7 commits into from
Oct 3, 2022
Merged

Support for NUOPC driver #199

merged 7 commits into from
Oct 3, 2022

Conversation

matsbn
Copy link
Contributor

@matsbn matsbn commented Sep 27, 2022

BLOM can now be coupled to CESM using the NUOPC driver. Also, wave forcing fields have been declared and wave-ocean coupling is supported when using the NUOPC driver.

Technical functioning of the NUOPC interface has been verified with cesm2_3_alpha08a. There is no change of results in BLOM standalone configurations or when the MCT driver is used.

Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matsbn ,
I should probably have a better grasp of NUOPC to make a full review of this PR, but at least I don't see anything obvious that looks strange to me.

phy/mod_difest.F Show resolved Hide resolved
Copy link
Contributor

@JorgSchwinger JorgSchwinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, although I can't really say much more than this.

@matsbn
Copy link
Contributor Author

matsbn commented Oct 3, 2022

Thanks for approving, @TomasTorsvik and @JorgSchwinger . This is a change that the BLOM devs have been informed about, and I thought it as useful to inform the iHAMOCC devs through a review request since it changes the folder structure under drivers. As mention in the PR, it should not impact current application of BLOM in NorESM. I'll proceed to merge.

@matsbn matsbn merged commit a0c5421 into NorESMhub:master Oct 3, 2022
@matsbn matsbn deleted the feature-nuopc branch May 24, 2023 22:15
jmaerz pushed a commit to jmaerz/BLOM that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants