Improvements/add group controlling #129 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be done using a floating action button.
…messages to groups.
… depending on the model type.
…persist the state.
…hNode in LiveData.
…mainly done to help restore the state of the ui. Instead the keys are not sorted based on the key index in the ui.
DomiR
pushed a commit
to DomiR/Android-nRF-Mesh-Library
that referenced
this pull request
Feb 15, 2019
…iconductor#155) * Replaces the scanner view with a group view. In order to scan/provision a device, use the add floating action button. * Group view adds support for creating/editing a group. When subscribing a model to a group a user may create or select an existing group * Model Configuration view now only sends messages to unicast addresses. * The app uses the provisioner sequence number as the tid * Fixed invalid endianness * Fixed updating a hardcoded key * Added missing `notifyAppKeyAdded(newAppKey)` & `notifyNetKeyAdded(key)` * Removed app key index when adding a key. The indexes of the app key list is not considered as the index. The index property of the `ApplicationKey ` object is what's considered as the index of the app key. Any users who were depending on the indexes will now have to sort the list based on the app key index of the application key. * Removed redundant `isProvisioned` property from `ProvisionedMeshNode` * Fixes swapped parameters * Fixes broken Parcelable implementation of `ProvisionedMeshnode` of `isProvisioned` and `blackListed`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notifyAppKeyAdded(newAppKey)¬ifyNetKeyAdded(key)ApplicationKeyobject is what's considered as the index of the app key. Any users who were depending on the indexes will now have to sort the list based on the app key index of the application key.isProvisionedproperty fromProvisionedMeshNodeProvisionedMeshnodeofisProvisionedandblackListed