-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: initial iv index transition date set to null #524
fix: initial iv index transition date set to null #524
Conversation
Hi this looks good to me, did you get a chance to test this on your end? |
I have tested with my changes only as of now. That was working. With just my changes though, it will always update as long as the received beacon is higher due to the lastTransition date issue that you fixed. Although that works in my case, it may raise some problems following the mesh spec. I haven't been able to test your changes in your branch though as I would have to make my device go through 2 iv index updates to see the result which will take quite a bit of time (> 192 hours I'm assuming) for testing to just to get 1 result. Unfortunately I'm occupied with other tasks at the moment to perform this level of testing |
OK, that's fine. FYI, the sample app contains a IV Test mode that overrides the time requirement. You could use this feature to do your testing as well :) Thanks for your contribution. Really appreciate it. |
@roshanrajaratnam Can you tell me how I can include this in my project (since it's not released on maven yet)? I would like to avoid putting it under source control of our main app. I heard about jitpack but since the repo is primarily an app, will it actually work? |
Hey yes I have not had time to release before I went on vacation. However if you notice the sample app includes the project directly. |
Hi @roshanrajaratnam. Any plans on releasing a maven build? |
Hi, I'm back at work on Tuesday and can do release. I need to fix a couple of other issues as well! |
This PR partially fixes #523.
It sets the default transition date to null and thus accepts an iv index update if it's receiving a beacon with higher ivindex in the network for the very first time