Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

feature file resolution does not work on windows machines #601

Closed
pfried opened this issue Aug 4, 2022 · 4 comments · Fixed by #602
Closed

feature file resolution does not work on windows machines #601

pfried opened this issue Aug 4, 2022 · 4 comments · Fixed by #602

Comments

@pfried
Copy link

pfried commented Aug 4, 2022

There is an issue where the feature runner cannot resolve the *.feature files on a windows machine

const scan = path.join(path.resolve(dir), '*.feature');

path.resolve will return a platform dependent path on windows something like C:\Users\maeckle but glob only works with forward slashes

I would have loved just changing the API to pass the whole glob pattern (that would also allow subdirectories **/*.feature) or different filenames, but that would be a breaking change. I will think about how to solve it, maybe something like this.

coderbyheart added a commit that referenced this issue Aug 4, 2022
@coderbyheart coderbyheart changed the title feature file resolution is broken on windows machines feature file resolution does not work on windows machines Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

🎉 This issue has been resolved in version 15.1.68-make-wildcards-work-on-windows.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderbyheart
Copy link
Member

coderbyheart commented Aug 4, 2022

Thanks for reporting, please not that we do not support Windows right now. We recommend to use WSL 2 if you must use Windows.

That said, could you try the fix from #602? It might solve your problem.

@pfried
Copy link
Author

pfried commented Aug 4, 2022

yeah that fix works, next issue upcoming tough #603

thanks for the fix

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

🎉 This issue has been resolved in version 15.1.68 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants