Feature/add auto-accept capability

[EbenezerGH]

I've added the ability to auto-accept result after the first QR code is scanned.

Closes #10

[westonal]

Small things, and you need to sign the commit. I can help, it's important to prove who wrote the code I think you will find it useful elsewhere too.

[westonal]

Kotlin style:

internal class Options(
    val showBarcodeBounds: Boolean,
    val autoAcceptResult: Boolean
) 

For long class headers.

[westonal]

This log is now in an incorrect place. Needs to show after onAccept and for the Snackbar path, it would actually show immediately now, instead of after.

Suggest: (note also inverting the if so it doesn't have a !)

            value?.let {
                if (options.autoAcceptResult) {
                    Timber.d("Accepted barcode automatically")
                    onAccept(it)
                 } else {
                    Snackbar.make(cameraSurfaceView, it, Snackbar.LENGTH_INDEFINITE)
                            .setAction(android.R.string.ok, { _ ->
                                Timber.d("Accepted barcode")
                                onAccept(it)
                            })
                            .show()
                }
            }

[westonal]

👍

Idea for future syntax:

startActivityForResult(Intent(this, ScanQrActivity::class.java)
    .withScannerOptions {
        if (BuildConfig.DEBUG) showBox()
        autoAccept()
    }, REQUEST_SCAN)

Then these ugly CAPITAL options and the room for error in the values passed to them disappears.

fun Intent.withScannerOptions(function: (IntentOptions) -> Unit): Intent {
    function(IntentOptions(this))
    return this
}

class IntentOptions(private intent: Intent) {
    fun autoAccept(){
        intent.putExtra(ScanQrActivity.AUTOACCEPT_RESULT, true)
    }
    //etc
}

You get the idea? Would be separate issue and PR.

[EbenezerGH]

I see, This is a good use of extension functions.

[westonal]

The two things you put 👍 on, still need doing/got lost during the attempt to sign.

[westonal]

3 nice to haves

[westonal]

This would be nice if matched the existing option:

const val OPTION_AUTOACCEPT_RESULT = "AUTOACCEPT_RESULT"

And put them side by side.

[westonal]

Be nice to revert this extra space.

[westonal]

be nice to newline before the ):

    private fun Intent?.toOptions() = Options(
            Options(this?.extras?.getBoolean(OPTION_SHOW_BARCODE_BOX) ?: false)	+            this?.extras?.getBoolean(OPTION_SHOW_BARCODE_BOX) ?: false,
            this?.extras?.getBoolean(AUTOACCEPT_RESULT) ?: false
    )