Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'copyToClipboard' function in common.js + a few fixes #2252

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Add 'copyToClipboard' function in common.js + a few fixes #2252

merged 1 commit into from
Jan 10, 2022

Conversation

Micdu70
Copy link
Contributor

@Micdu70 Micdu70 commented Jan 9, 2022

No description provided.

Novik
Novik reviewed Jan 9, 2022
View reviewed changes
plugins/bulk_magnet/init.js
}
}
return(ret);
}

plugin.copyProperty = function(type)
theWebUI.copyProperty = function(type)
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really have plan to use 'theWebUI.copyProperty' somewhere else?
If no, then do not extend global interface 'theWebUI', use local 'plugin' interface instead, please.
Pollution of global interfaces with a non-common functions is not a good thing.

Copy link
Contributor Author

@Micdu70 Micdu70 Jan 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really would like to keep using the 'plugin' interface but it doesn't work:

=> "plugin.copyProperty()":
----- Get plugin is not defined error when using double quotes in 'theContextMenu.add' call.
----- Without double quotes, all 3 'copyProperty' functions are called when the context menu is opened in ruTorrent.

=> "plugin.copyProperty" without "()" at the end:
----- Get plugin is not defined error when using double quotes in 'theContextMenu.add' call.
----- Without double quotes, copyProperty function is never called. (EDIT: It worked before the merge of PR #2236.)

Copy link
Owner

@Novik Novik Jan 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about previous implementation, does it work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous implementation doesn't seem to work (at least not with my personal ruTorrent installation). I don't know the last time this worked.

@Novik Novik merged commit 2897543 into Novik:master Jan 10, 2022
@Micdu70
Copy link
Contributor Author

Micdu70 commented Jan 10, 2022

@Novik & @stickz For your information, "plugin.functionName" in 'theContextMenu.add' call stopped functioning since the merge of PR #2236.

@Novik
Copy link
Owner

Novik commented Jan 10, 2022

@Micdu70 I already fixed this, thanks.

@Micdu70 Micdu70 deleted the patch-11 branch January 10, 2022 10:06
stickz added a commit to stickz/ruTorrent that referenced this pull request Jan 12, 2022
@stickz
Squashed commit of the following:
b32728c 
commit 319977d
Merge: e8f0fef 6cc49f4
Author: Novik <[email protected]>
Date:   Wed Jan 12 15:52:14 2022 +0300

    Merge pull request Novik#2261 from njutn95/patch-1

    Fix the typo/syntax error in the static method call

commit 6cc49f4
Author: njutn95 <[email protected]>
Date:   Wed Jan 12 13:01:27 2022 +0100

    Fix the typo/syntax error in the static method call

commit e8f0fef
Merge: cc8d4b1 13a75f5
Author: Novik <[email protected]>
Date:   Mon Jan 10 14:43:22 2022 +0300

    Merge pull request Novik#2254 from Micdu70/patch-7

    Fix task.php

commit 13a75f5
Author: Micdu70 <[email protected]>
Date:   Mon Jan 10 12:42:10 2022 +0100

    Fix task.php

commit cc8d4b1
Merge: 25580d7 fec4bdd
Author: Novik <[email protected]>
Date:   Mon Jan 10 12:36:59 2022 +0300

    Merge pull request Novik#2253 from stickz/Namespace-Fix

    Fix loading utility classes from namespaces

commit fec4bdd
Author: stickz <[email protected]>
Date:   Mon Jan 10 04:01:07 2022 -0500

    Fix PHP Notice

commit 25580d7
Author: Novik <[email protected]>
Date:   Mon Jan 10 11:28:42 2022 +0300

    fix context menu error

commit 2897543
Merge: 795bd19 bcea8a6
Author: Novik <[email protected]>
Date:   Mon Jan 10 11:07:21 2022 +0300

    Merge pull request Novik#2252 from Micdu70/patch-11

    Add 'copyToClipboard' function in common.js + a few fixes

commit d92e194
Author: stickz <[email protected]>
Date:   Mon Jan 10 02:53:31 2022 -0500

    Go to end of exploded array instead

commit bcea8a6
Author: Micdu70 <[email protected]>
Date:   Sat Jan 8 19:04:30 2022 +0100

    Add 'copyToClipboard' function in common.js + a few fixes

commit d12228d
Author: stickz <[email protected]>
Date:   Mon Jan 10 01:27:00 2022 -0500

    Fix loading utility classes

commit 795bd19
Merge: 0d44ec9 27e4882
Author: Novik <[email protected]>
Date:   Sun Jan 9 14:20:14 2022 +0300

    Merge pull request Novik#2241 from stickz/MemoryLeakFixes

     Improve memory management

commit 0d44ec9
Merge: fd35e22 db16d33
Author: Novik <[email protected]>
Date:   Sun Jan 9 14:07:37 2022 +0300

    Merge pull request Novik#2247 from stickz/Utility2

    Refactor code & implement autoloader

commit db16d33
Author: stickz <[email protected]>
Date:   Sat Jan 8 18:49:52 2022 -0500

    Fix json.php

commit fd35e22
Merge: be26ce3 0d91672
Author: Novik <[email protected]>
Date:   Fri Jan 7 14:24:08 2022 +0300

    Merge pull request Novik#2251 from Micdu70/patch-11

    Fix 'check_port' and 'extsearch' plugins

commit 0d91672
Author: Micdu70 <[email protected]>
Date:   Fri Jan 7 10:46:15 2022 +0100

    Fix 'check_port' and 'extsearch' plugins

commit d815e75
Author: stickz <[email protected]>
Date:   Thu Jan 6 16:53:14 2022 -0500

    Fix third party plugin compatibility

commit 2ec6b86
Author: stickz <[email protected]>
Date:   Thu Jan 6 16:22:21 2022 -0500

    Remove $user arg for paths

commit 3f60a43
Author: stickz <[email protected]>
Date:   Thu Jan 6 16:12:12 2022 -0500

    Remove ruTorrentConfig

commit df7c0d0
Author: stickz <[email protected]>
Date:   Thu Jan 6 16:09:17 2022 -0500

    Fix whitespaces

commit 9f3aee8
Author: stickz <[email protected]>
Date:   Thu Jan 6 16:06:41 2022 -0500

    Revert ruTorrentConfig class

commit be26ce3
Merge: 9be549f 28fa12c
Author: Novik <[email protected]>
Date:   Mon Jan 3 13:20:19 2022 +0300

    Merge pull request Novik#2249 from Micdu70/patch-11

    Fix Novik#2248

commit 28fa12c
Author: Micdu70 <[email protected]>
Date:   Mon Jan 3 10:25:41 2022 +0100

    Fix Novik#2248

commit c63b61a
Author: stickz <[email protected]>
Date:   Sun Jan 2 21:55:53 2022 -0500

    Refactor more code

commit 6429984
Author: stickz <[email protected]>
Date:   Sun Jan 2 13:03:15 2022 -0500

    Refactor code

commit 27e4882
Author: stickz <[email protected]>
Date:   Thu Dec 30 01:20:31 2021 -0500

     Improve memory management
@Micdu70 Micdu70 mentioned this pull request Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Novik Novik Novik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Micdu70 @Novik