Adjust status bar and top menu #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevenski
force-pushed
the
status-bar
branch
3 times, most recently
from
28d24a0 to
c938023
Compare
- Change status bar position to static because height of the navbar, the main content and the status bar has been set to be calculated dynamically according to the window height. - Define status bar border color and background color using css variables, with CSS gradient for background in use in some themes (Excel, Oblivion). - Remove verbose utility class names on status bar. - Remove unused outdated CSS rules. - Set a max height on the collapsible navbar menu to fit in some extreme situations where one might have a screen with small height or a collapsible menu with a lot of buttons.
|
There is a problem with webui resizing introduced by this pull request. Resize web browser window to mobile and open the topmenu. Keep it open and resize back to desktop. The background for the menu items on desktop changes to white. The topmenu for mobile remains open on resize. |
- Fix top menu collapsing when opening dialog windows on mobile. - Fix top menu not collapsing when switching from mobile to desktop.
|
This is an old bug introduced by an earlier commit. The new commit also fixes this issue: #2814 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch contains some unnoticeable changes by non-developers. It serves mainly for a clean-up purpose.