Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute WebUi space using flex layout #2826

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Conversation

jevenski
Copy link
Contributor

  • Resize category list, torrent list table and torrent detail tabs using flex-basis property. This reduces the amount of JS doing resizing work and lets CSS take over the space distribution.
  • Add a deprecation warning for the old theWebUI.resizeTop(w, h) method and suggest using the new simplified theWebUI.resizeTop(h) method.
  • Fix an error that occurs when traffic graph is shrinked down to less than 1px high.

Fixes #2817

- Resize category list, torrent list table and torrent detail tabs
  using `flex-basis` property. This reduces the amount of JS doing
  resizing work and lets CSS take over the space distribution.
- Add a deprecation warning for the old `theWebUI.resizeTop(w, h)`
  method and suggest using the new simplified `theWebUI.resizeTop(h)`
  method.
- Fix an error that occurs when traffic graph is shrinked down to
  less than 1px high.
@jevenski
Copy link
Contributor Author

This patch also fixes this issue mentioned in an early feedback for v5.0.

I also found that clicking on certain tabs in all the other themes causes the whole bottom section to grow vertically by 1 or 2 pixels. The tabs that do this the most often are the history and plugins tabs, but it happens with others depending on the theme. (Incidentally, this doesn't happen in the MaterialDesign theme.) I thought that it might be caused by the content of the active tab having x-overflow content, which could cause the scrollbar to appear and maybe bump the tab upward. But it happens even if I make the various fields in each tab narrower so that everything fits on the screen, so I'm not sure what's really making it happen. This isn't a big usability issue or anything. It's just a quirky UI thing where I can see the tab bar moving slightly up and down as I click through the tabs.

Originally posted by @Airman8 in #2721 (comment)

@stickz
Copy link
Collaborator

stickz commented Dec 14, 2024

@jevenski This will be the next pull request merged. Afterwards, we need a hotfix for all platforms on v5.1 (without the deprecation). There's an issue when I take my web browser out of maximize mode. The traffic graph does not update.
ruTorrent_max

ruTorrent_max2

@koblack
Copy link
Contributor

koblack commented Dec 14, 2024

Toggle details [F6] does not work correctly.
After pressing [F6] only the contents of the tab are hidden but this part of the window remains visible.

Screenshot:
image

- Fix toggle torrent detail tab pages error.
- Fix incorrect traffic graph dimension when maximizing and unmaximize
  browser window.
- Fix torrent list height minor shifting issue.
@stickz
Copy link
Collaborator

stickz commented Dec 15, 2024

Thanks @jevenski. I'll tag ruTorrent v5.1.4 once this is backported for a hotfix!

@stickz stickz merged commit cc511a9 into Novik:develop Dec 15, 2024
@jevenski jevenski deleted the flex-resize branch December 15, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants