Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Bash] Only the embedded license content of the latest version can be loaded correctly in PM UI when there are multiple versions in the same package from local feeds #10670

Closed
v-luzh opened this issue Mar 19, 2021 · 3 comments · Fixed by NuGet/NuGet.Client#5296
Assignees
Labels
Found:ManualTests Functionality:VisualStudioUI Package Manager UI et al Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:VS.Client Type:Bug
Milestone

Comments

@v-luzh
Copy link

v-luzh commented Mar 19, 2021

Details about Problem

NuGet version: NuGet Client Dev\5.10.0.7170
VS Version: Main\31118.282
OS: Windows-10-Enterprise-20h1

Repro steps and/or sample project

  1. Create a Class Library (.NET Framework 4.8) in VS and build the solution.
  2. In the Developer Command Prompt for VS, cd to the project path and create a nuspec file by executing command “nuget spec”.
  3. Make an image file (size limited to 1 MB with PNG format and 128x128 resolution) and locate in the package.
  4. Make a License.txt and locate in the package.
  5. Add following to nuspec file
<package> 
  <metadata> 
    ... 
    <icon>images\icon.png</icon> 
    <license type="file">License.txt</license> 
  </metadata> 
  <files> 
    ... 
    <file src="[ProjectPath]\icon.png" target="images\" /> 
    <file src="[ProjectPath]\License.txt" target="" /> 
  </files> 
</package> 
  1. Pack the package to local path by executing command “nuget pack”.
  2. Pack the same package with another version following step3-step6.
  3. Create a C# Console App (.NET Framework 4.8) in VS and open PM UI of the project/solution.
  4. Add the package source as a local feed in Settings->NuGet Package Manager->Package Sources.
  5. Select the new added local feed in the Package source dropdown box in the PM UI and click the package on the left panel.
  6. Choose a package version in the “Version” drop-down box on the right panel and click the “View License” link of every version.

Expected

The embedded license content of every version can be loaded correctly in the PM UI.

Actual

Only the embedded license content of the latest version can be loaded correctly as below.
image

Notes

  1. Repro on both project-level PM UI and solution-level PM UI.
  2. Not a regression since it start to repro from the beginning of the embedded license feature in dev-rrelyea-remotefileservice\5.9.0.14330.
@donnie-msft
Copy link
Contributor

maybe related #10546

@zkat zkat added the Type:Bug label Mar 25, 2021
@nkolev92 nkolev92 changed the title [Bug Bash] Only the embedded license content of the latest version can be loaded correctly in PM UI when there are multiple versions in the same package [Bug Bash] Only the embedded license content of the latest version can be loaded correctly in PM UI when there are multiple versions in the same package from local feeds Sep 23, 2021
@aortiz-msft
Copy link
Contributor

@v-luzh - We could not repro with packages hosted in NuGet.org which is the most common scenario.

@aortiz-msft aortiz-msft added the Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. label Sep 23, 2021
@v-luzh
Copy link
Author

v-luzh commented Nov 1, 2021

@aortiz-msft, OK, Thanks. I changed the pipeline to Icebox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Found:ManualTests Functionality:VisualStudioUI Package Manager UI et al Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:VS.Client Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants