Fix license display when it comes from a File

[martinrrm]

Bug

Fixes: NuGet/Home#12060
Fixes: NuGet/Home#10670
Regression? Last working version:

Description

NuGetPackageFileService.GetEmbeddedLicenseAsync tries to get a URI from an in-memory cache, but the cache is never updated. With this change, I'm adding the correct information to the cache when the link is being created. This issue only occurs when the License comes from a file.

Fix for NuGet/Home#10670:

PR Checklist

• PR has a meaningful title

• PR has a linked issue.

• Described changes

• Tests

  • Automated tests added
  • OR
  • Test exception
  • OR
  • N/A

• Documentation

  • Documentation PR or issue filled
  • OR
  • N/A

[zivkan]

@martinrrm can you check if there is any telemetry emit before your change to let us know that getting an embedded licence has failed? If not, please add some, because if the cache decides its too full and decides to evict the data in the short time between adding it to the cache and then reading it from the cache, we're still going to have problems.

If we're not going to fix the fundamental design flaw, we should at least have telemetry.

[martinrrm]

@zivkan Sorry for the late response, we do emit telemetry for faults here.

NuGet.Client/src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Services/NuGetPackageFileService.cs

Lines 126 to 128 in 629ec93

	var exception = new CacheMissException();
	await _nuGetTelemetryProvider.PostFaultAsync(exception, typeof(NuGetPackageFileService).FullName, nameof(NuGetPackageFileService.GetEmbeddedLicenseAsync));
	return null;

[donnie-msft]

Since this change is to the utilities, might the PR also fix NuGet/Home#10670 ?

NuGet.Client/src/NuGet.Clients/NuGet.PackageManagement.UI/Models/DetailedPackageMetadata.cs

Line 116 in 636dfa5

public IReadOnlyList<IText> LicenseLinks => PackageLicenseUtilities.GenerateLicenseLinks(this);

[martinrrm]

@donnie-msft Confirmed that this PR also fixes that issue, added a gif to demonstrate.

[donnie-msft]

🎉 Thanks for checking on the other bug. "2 bugs with 1 PR"!

I left some comments which I believe are techdebt. Ideally, fix them in this PR. Otherwise, please create a follow-up issue to address them.