Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow package restore when solution is not saved for project.json scenarios #1081

Closed
yishaigalatzer opened this issue Jul 30, 2015 · 0 comments
Closed

Allow package restore when solution is not saved for project.json scenarios #1081

yishaigalatzer opened this issue Jul 30, 2015 · 0 comments
Assignees
@johnataylor
Milestone
3.2

Comments

@yishaigalatzer
Copy link

When a solution is not saved, we don't allow package restore. This was important in package.config world but does not apply for project.json scenarios.

We need to either find a way to allow it, or present a clear warning to the user.
@yishaigalatzer yishaigalatzer added this to the 3.1.2 milestone Jul 30, 2015
deepakaravindr pushed a commit to NuGetArchive/NuGet.PackageManagement that referenced this issue Aug 11, 2015
Added a ThrowIfNotAvailable to ISolutionManager.
3b9b8ff 
Updated BuildIntegratedProjectUtility to handle cases where
solutionDirectory is null or is a relative path

Fixes NuGet/Home#1081
deepakaravindr pushed a commit to NuGetArchive/NuGet.VisualStudioExtension that referenced this issue Aug 11, 2015
Fixes NuGet/Home#1081
83140bf 
1. Changed IsSolutionOpen to return even if the solution required a
'Save As'. Note that this means that the SolutionDirectory would be the
project directory until the solution gets saved. And, the solution file could
get saved to a different location
2. But, Throwing an exception that the solution is not saved from the UI
and from Powershell console
3. A dded event listeners for SolutionSaveAs and SolutionSave. Now,
the project cache, NuGet settings among other things get reset after an
unsaved solution has been saved
3. This change is applicable to all kinds of solutions, BuildIntegrated
projects only solution, classic projects only with packages.config and the
hybrid scenarios as well
4. Test: Verified that the value of globalPackagesFolder setting
relative to solution directory changes after saving an unsaved solution
such that solution file is 1 folder above the project folder
directory
deepakaravindr added a commit to NuGetArchive/NuGet.PackageManagement that referenced this issue Aug 11, 2015
@deepakaravindr
Added a ThrowIfNotAvailable to ISolutionManager.
8443194 
Updated BuildIntegratedProjectUtility to handle cases where
solutionDirectory is null or is a relative path

Fixes NuGet/Home#1081
deepakaravindr added a commit to NuGetArchive/NuGet.VisualStudioExtension that referenced this issue Aug 11, 2015
@deepakaravindr
Fixes NuGet/Home#1081
29ad311 
1. Changed IsSolutionOpen to return even if the solution required a
'Save As'. Note that this means that the SolutionDirectory would be the
project directory until the solution gets saved. And, the solution file could
get saved to a different location
2. But, Throwing an exception that the solution is not saved from the UI
and from Powershell console
3. A dded event listeners for SolutionSaveAs and SolutionSave. Now,
the project cache, NuGet settings among other things get reset after an
unsaved solution has been saved
3. This change is applicable to all kinds of solutions, BuildIntegrated
projects only solution, classic projects only with packages.config and the
hybrid scenarios as well
4. Test: Verified that the value of globalPackagesFolder setting
relative to solution directory changes after saving an unsaved solution
such that solution file is 1 folder above the project folder
directory
@deepakaravindr deepakaravindr mentioned this issue Aug 11, 2015
Closed
deepakaravindr added a commit to NuGetArchive/NuGet.PackageManagement that referenced this issue Aug 14, 2015
@deepakaravindr
Added a ThrowIfNotAvailable to ISolutionManager.
1b0b770 
Updated BuildIntegratedProjectUtility to handle cases where
solutionDirectory is null or is a relative path

Fixes NuGet/Home#1081
deepakaravindr added a commit to NuGetArchive/NuGet.VisualStudioExtension that referenced this issue Aug 14, 2015
@deepakaravindr
Fixes NuGet/Home#1081
10c2453 
1. Changed IsSolutionOpen to return even if the solution required a
'Save As'. Note that this means that the SolutionDirectory would be the
project directory until the solution gets saved. And, the solution file could
get saved to a different location
2. But, Throwing an exception that the solution is not saved from the UI
and from Powershell console
3. A dded event listeners for SolutionSaveAs and SolutionSave. Now,
the project cache, NuGet settings among other things get reset after an
unsaved solution has been saved
3. This change is applicable to all kinds of solutions, BuildIntegrated
projects only solution, classic projects only with packages.config and the
hybrid scenarios as well
4. Test: Verified that the value of globalPackagesFolder setting
relative to solution directory changes after saving an unsaved solution
such that solution file is 1 folder above the project folder
directory
deepakaravindr added a commit to NuGetArchive/NuGet.PackageManagement that referenced this issue Aug 14, 2015
@deepakaravindr
Added a ThrowIfNotAvailable to ISolutionManager.
494a670 
Updated BuildIntegratedProjectUtility to handle cases where
solutionDirectory is null or is a relative path

Fixes NuGet/Home#1081
deepakaravindr added a commit to NuGetArchive/NuGet.VisualStudioExtension that referenced this issue Aug 14, 2015
@deepakaravindr
Fixes NuGet/Home#1081
4e9de74 
1. Changed IsSolutionOpen to return even if the solution required a
'Save As'. Note that this means that the SolutionDirectory would be the
project directory until the solution gets saved. And, the solution file could
get saved to a different location
2. But, Throwing an exception that the solution is not saved from the UI
and from Powershell console
3. A dded event listeners for SolutionSaveAs and SolutionSave. Now,
the project cache, NuGet settings among other things get reset after an
unsaved solution has been saved
3. This change is applicable to all kinds of solutions, BuildIntegrated
projects only solution, classic projects only with packages.config and the
hybrid scenarios as well
4. Test: Verified that the value of globalPackagesFolder setting
relative to solution directory changes after saving an unsaved solution
such that solution file is 1 folder above the project folder
directory
deepakaravindr added a commit to NuGetArchive/NuGet.VisualStudioExtension that referenced this issue Aug 18, 2015
@deepakaravindr
Fixes NuGet/Home#1081
52b6a01 
1. Changed IsSolutionOpen to return even if the solution required a
'Save As'. Note that this means that the SolutionDirectory would be the
project directory until the solution gets saved. And, the solution file could
get saved to a different location
2. But, Throwing an exception that the solution is not saved from the UI
and from Powershell console
3. A dded event listeners for SolutionSaveAs and SolutionSave. Now,
the project cache, NuGet settings among other things get reset after an
unsaved solution has been saved
3. This change is applicable to all kinds of solutions, BuildIntegrated
projects only solution, classic projects only with packages.config and the
hybrid scenarios as well
4. Test: Verified that the value of globalPackagesFolder setting
relative to solution directory changes after saving an unsaved solution
such that solution file is 1 folder above the project folder
directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnataylor johnataylor

Labels
None yet
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
3 participants
@yishaigalatzer @deepakaravindr @johnataylor