Return to previous colors for Tab Count badges #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
approved these changes
Sep 15, 2021
aortiz-msft
approved these changes
Sep 16, 2021
zivkan
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#10896
Regression? Last working version:
Description
In the new dark theme, the type of buttons we're using don't pick up accent colors. After working with UX and IDE teams, it was determined there is no existing VS token for us to use here, so we are changing to a different System token which achieves the existing foreground/background colors.
Goal (from 16.11.2 )
Dark theme:
Light theme:
Blue theme:
Blue extra contrast:
High Contrast:
Before PR (17.0)
Dark theme:
Light theme:
Blue theme:
Blue extra contrast:
High contrast:
After PR (17.x)
Dark theme:
Light theme:
Blue theme:
Blue extra contrast:
High contrast:
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation