Local feeds no longer show a 0 Download Count #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jebriede
approved these changes
Sep 20, 2021
src/NuGet.Core/NuGet.Protocol/Model/LocalPackageSearchMetadata.cs
Outdated
Show resolved
Hide resolved
|
@erdembayar please review if you can. I think you may have the most recent experience in this area. |
zivkan
approved these changes
Sep 20, 2021
erdembayar
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11012
Regression? Last working version:
Description
Local feeds have defaulted the Download Count to 0. However, this causes hits to the Global Packages Folder to erroneously display a 0, and an unnecessary 0 to be shown when a Local package source is selected.
This PR introduces a new bug that I believe is lower impact and less misleading than the current behavior: when a V2 feed is used, and in the details pane, the installed version is selected in the Versions dropdown, the Download Count will be hidden. (see below).
Before/After setting count to null for local feeds.
Before / After with nuget.org source
Before / after with a V2 feed & same version selected in details (new bug w/ this PR)
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation