Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: PackageSourceMapping inconsistencies should be reported #11385

Closed
lanfeust69 opened this issue Nov 15, 2021 · 2 comments · Fixed by NuGet/NuGet.Client#4374
Closed

[Bug]: PackageSourceMapping inconsistencies should be reported #11385

lanfeust69 opened this issue Nov 15, 2021 · 2 comments · Fixed by NuGet/NuGet.Client#4374
Assignees
@nkolev92
Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Area:PackageSourceMapping Issues related to the package source mapping feature Category:Quality Week Issues that should be considered for quality week Functionality:Restore Priority:2 Issues for the current backlog. Type:Bug
Milestone
Sprint 2022-01

Comments

@lanfeust69
Copy link

NuGet Product(s) Affected

NuGet.exe, MSBuild.exe, dotnet.exe

Current Behavior

When there is a no source matching the source name of a <packageSourceMapping> (typically a typo, or maybe after a git merge), a restore can fail with a very generic error

error NU1100: Unable to resolve '<package>' for '<framework>'

Desired Behavior

There should be a more helpful message.

Maybe a warning at the beginning if there is no source corresponding to a <packageSourceMapping> entry.

Additional Context

No response
@lanfeust69 lanfeust69 added Triage:Untriaged Type:DCR Design Change Request labels Nov 15, 2021
@dominoFire dominoFire added Area:PackageSourceMapping Issues related to the package source mapping feature Area:ErrorHandling warnings and errors/log messages & related error codes. Triage:Discussions Triage:Untriaged and removed Triage:Untriaged labels Nov 16, 2021
@zivkan zivkan added Type:Bug Functionality:Restore Priority:2 Issues for the current backlog. Category:Quality Week Issues that should be considered for quality week and removed Type:DCR Design Change Request Triage:Discussions labels Nov 18, 2021
@nkolev92 nkolev92 changed the title [DCR]: PackageSourceMapping inconsistencies should be reported [Bug]: PackageSourceMapping inconsistencies should be reported Nov 18, 2021
@nkolev92 nkolev92 added this to the Sprint 2021-11 milestone Nov 22, 2021
@kartheekp-ms
Copy link
Contributor

Once this issue has been fixed, we may have to update the docs to address https://github.com/NuGet/docs.microsoft.com-nuget/issues/2571

@nkolev92
Copy link
Member

Reviewing NU1102 and the likes also makes sense for these scenarios.

@nkolev92 nkolev92 mentioned this issue Dec 21, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Area:PackageSourceMapping Issues related to the package source mapping feature Category:Quality Week Issues that should be considered for quality week Functionality:Restore Priority:2 Issues for the current backlog. Type:Bug
Projects
None yet
Milestone
Sprint 2022-01
Development

Successfully merging a pull request may close this issue.

Improve restore error messages in source mapping scenarios NuGet/NuGet.Client
5 participants
@dominoFire @lanfeust69 @nkolev92 @zivkan @kartheekp-ms