-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve restore error messages in source mapping scenarios #4374
Merged
nkolev92
merged 6 commits into
dev
from
dev-nkolev92-improveRestoreErrorMessagesInSourceMappingScenarios
Jan 3, 2022
Merged
Improve restore error messages in source mapping scenarios #4374
nkolev92
merged 6 commits into
dev
from
dev-nkolev92-improveRestoreErrorMessagesInSourceMappingScenarios
Jan 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
reviewed
Dec 22, 2021
src/NuGet.Core/NuGet.Commands/RestoreCommand/Diagnostics/UnresolvedMessages.cs
Outdated
Show resolved
Hide resolved
erdembayar
reviewed
Dec 22, 2021
src/NuGet.Core/NuGet.Commands/RestoreCommand/Diagnostics/UnresolvedMessages.cs
Outdated
Show resolved
Hide resolved
erdembayar
approved these changes
Dec 22, 2021
martinrrm
approved these changes
Dec 23, 2021
ghost
added
the
Status:No recent activity
PRs that have not had any recent activity and will be closed if the label is not removed
label
Dec 30, 2021
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
jeffkl
approved these changes
Jan 3, 2022
ghost
removed
the
Status:No recent activity
PRs that have not had any recent activity and will be closed if the label is not removed
label
Jan 3, 2022
nkolev92
deleted the
dev-nkolev92-improveRestoreErrorMessagesInSourceMappingScenarios
branch
January 3, 2022 22:17
martinrrm
pushed a commit
that referenced
this pull request
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11385
Regression? Last working version:
Description
Some failure scenarios, in particular, NU1100, NU1101, NU1102, NU1103 relate to not being able to resolve a certain package from sources.
PackageSourceMapping filters some of those sources.
This changes adds extra details in those scenarios in source mapping scenarios, where appropriate (ie. source mapping filtered out some sources).
NU1100
Before:
C:\Code\Temp\NU1000SourceMapping\NU1000SourceMapping.csproj : error NU1100: Unable to resolve 'NuGet.VersioningBla (>= 6.0.0)' for 'net6.0'.
After:
NU1101
Before:
C:\Code\Temp\NU1000SourceMapping\NU1000SourceMapping.csproj : error NU1101: Unable to find package NuGet.VersioningBla. No packages exist with this id in source(s): nuget-build
After:
NU1102
NU1103 works the same way.
Before:
After:
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation