Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package Source Mapping utility always appends package ID #12839

Closed
donnie-msft opened this issue Aug 23, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5377
Closed

Package Source Mapping utility always appends package ID #12839

donnie-msft opened this issue Aug 23, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5377
Assignees
@donnie-msft
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Functionality:VisualStudioUI Package Manager UI et al Product:VS.Client Type:Bug
Milestone
6.8

Comments

@donnie-msft
Copy link
Contributor

NuGet Product Used

Visual Studio Package Management UI

Product Version

17.8

Worked before?

No response

Impact

None

Repro Steps & Context

The logic in https://github.com/NuGet/NuGet.Client/blob/a39baac/src/NuGet.Clients/NuGet.PackageManagement.UI/Utility/PackageSourceMappingUtility.cs#L45 always Appends the package ID.
I'm not sure if this causes a problem today, but in a subsequent PR, I want to have an accurate count of newly mapped packages. So, I'd like this to only append package ID if it's not already included.

Verbose Logs

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donnie-msft donnie-msft

Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Functionality:VisualStudioUI Package Manager UI et al Product:VS.Client Type:Bug
Projects
None yet
Milestone
6.8
2 participants
@zivkan @donnie-msft