Ensure top-level package isn't duplicated in new source mappings #5374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
reviewed
Aug 24, 2023
src/NuGet.Clients/NuGet.PackageManagement.UI/Utility/PackageSourceMappingUtility.cs
Outdated
Show resolved
Hide resolved
|
Thanks for the reviews. I've integrated this change into #5377 which supersedes this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12839
Regression? Last working version:
Description
I'm not sure if this causes a problem today, but in a subsequent PR, I want to have an accurate count of newly mapped packages. So, I'd like this to only append package ID if it's not already included.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation