Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGetAuditMode doesn't work for SDK style projects in VS 17.8 #13003

Closed
zivkan opened this issue Nov 9, 2023 · 2 comments
Closed

NuGetAuditMode doesn't work for SDK style projects in VS 17.8 #13003

zivkan opened this issue Nov 9, 2023 · 2 comments
Assignees
Labels
Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Type:Bug
Milestone

Comments

@zivkan
Copy link
Member

zivkan commented Nov 9, 2023

NuGet Product Used

Visual Studio Package Management UI

Product Version

VS 17.8

Worked before?

It's a new feature

Impact

It bothers me. A fix would be nice

Repro Steps & Context

The way that NuGet & the .NET SDK works in Visual Studio is that https://github.com/dotnet/project-system sends NuGet project information (via an API called NominateProjectAsync, so we typically call it a "nomination"), which NuGet then uses in order to perform the restore. Unfortunately I forgot to add NuGetAuditMode to the list of properties sent to NuGet, so NuGet has no way of knowing this property value in VS 17.8:

Verbose Logs

No response

@zivkan zivkan self-assigned this Nov 9, 2023
@nkolev92 nkolev92 added the Priority:1 High priority issues that must be resolved in the current sprint. label Nov 9, 2023
@nkolev92 nkolev92 modified the milestone: 6.9 Nov 9, 2023
@nkolev92 nkolev92 added this to the 6.9 milestone Feb 28, 2024
@nkolev92
Copy link
Member

This was fixed in 6.9, correct?

@zivkan
Copy link
Member Author

zivkan commented Feb 29, 2024

Yes, yes it was: dotnet/project-system#9320

thanks for noticing and cleaning up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Type:Bug
Projects
None yet
Development

No branches or pull requests

2 participants