Set NuGetAudit property defaults in MSBuild #5469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
commented
Oct 23, 2023
nkolev92
previously approved these changes
Oct 23, 2023
jeffkl
previously approved these changes
Oct 23, 2023
jebriede
previously approved these changes
Oct 26, 2023
nkolev92
previously approved these changes
Oct 30, 2023
donnie-msft
reviewed
Nov 1, 2023
test/NuGet.Core.Tests/NuGet.Commands.Test/RestoreCommandTests/Utility/AuditUtilityTests.cs
Outdated
Show resolved
Hide resolved
zivkan
commented
Nov 9, 2023
| @@ -163,6 +165,8 @@ function Test-NetCoreVSandMSBuildNoOp { | |||
| } | |||
|
|
|||
| function Test-NetCoreTargetFrameworksVSandMSBuildNoOp { | |||
| [SkipTest('https://github.com/NuGet/Home/issues/13003')] | |||
There was a problem hiding this comment.
I updated the PR description, but this is failing because I forgot to update dotnet/project-system to pass NuGetAuditMode in nomination:
We can either:
- Merge this PR with the skip and then I'll need to undo the skip once project-system merged my PR and inserts into VS
- Wait until project-system merges and inserts the fix, then I need to update this PR to remove these skips.
There was a problem hiding this comment.
personally, I'm fine with merging the skip.
Let's just get it done :)
nkolev92
approved these changes
Nov 9, 2023
jeffkl
approved these changes
Nov 9, 2023
Nigusu-Allehu
pushed a commit
that referenced
this pull request
Nov 15, 2023
Nigusu-Allehu
pushed a commit
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12960
Regression? No
Description
In order to make Visual Studio's project properties window more user friendly, we need to set these properties default values in project evaluation. See dotnet/project-system#9246 for more info.
Since this breaks NuGetAudit's telemetry for telling the difference between "explicit enable" and "implicit enable", it was changed to just "enabled" or "disabled". This is a breaking change, so telemetry queries need to be updated, but it reduces long term confusion for people looking at telemetry, as they no longer need to understand what implicit/explicit really mean.
Added skips for 2 VS E2E tests that are failing because project system's nomination isn't passing through the
NuGetAuditModeproperty. I already have a PR to fix that, but we have to wait until it's merged into the dotnet/project-system repo, and then dotnet/project-system is inserted into VS, before these tests can work. Fortunately project-system inserts pretty much every day, so it shouldn't take long, just depends on how quick the PR gets merged. We can either merge this PR with the skips and I'll need to revert the skips afterwards, or we can wait for project-system to merge and insert, then I can update this PR.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation