Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support $(RuntimeIdentifier) #3641

Closed
emgarten opened this issue Oct 11, 2016 · 0 comments
Closed

Support $(RuntimeIdentifier) #3641

emgarten opened this issue Oct 11, 2016 · 0 comments
Assignees
@emgarten
Milestone
4.0 RC

Comments

@emgarten
Copy link
Member

Add support for $(RuntimeIdentifier) in addition to $(RuntimeIdentifiers)
@emgarten emgarten self-assigned this Oct 11, 2016
@emgarten emgarten added this to the 3.6 RC milestone Oct 11, 2016
@emgarten emgarten mentioned this issue Oct 11, 2016
Merged
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Oct 11, 2016
@emgarten
Conditions for targets/props imports
3fc5aff 
Framework conditions for targets/props are added only when a project uses cross targeting. For scenarios with a single framework under $(TargetFramework) buildCrossTargeting will be left out and there will be no framework conditions to block the imports.

In addition to this a new property has been added to allow control over package imports: ExcludeRestorePackageImports. This flag is used at restore time to avoid imports from packages changing the inputs to restore, without this it is possible to get different results between the first and second restore.

This change also contains support for nooping when writing out targets/props files. Currently the check is a simple string compare on the files since these files are small. Nooping is now a major benefit since all NETCore projects reference the SDK package, without nooping on the targets/props files MSBuild will always end up rebuilding everything for NETCore solutions.

Fixes NuGet/Home#3588
Fixes NuGet/Home#3637
Fixes NuGet/Home#3604
Fixes NuGet/Home#3641
Fixes NuGet/Home#3199
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Oct 11, 2016
@emgarten
Conditions for targets/props imports
e021efc 
Framework conditions for targets/props are added only when a project uses cross targeting. For scenarios with a single framework under $(TargetFramework) buildCrossTargeting will be left out and there will be no framework conditions to block the imports.

In addition to this a new property has been added to allow control over package imports: ExcludeRestorePackageImports. This flag is used at restore time to avoid imports from packages changing the inputs to restore, without this it is possible to get different results between the first and second restore.

This change also contains support for nooping when writing out targets/props files. Currently the check is a simple string compare on the files since these files are small. Nooping is now a major benefit since all NETCore projects reference the SDK package, without nooping on the targets/props files MSBuild will always end up rebuilding everything for NETCore solutions.

Fixes NuGet/Home#3588
Fixes NuGet/Home#3637
Fixes NuGet/Home#3604
Fixes NuGet/Home#3641
Fixes NuGet/Home#3199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emgarten emgarten

Labels
None yet
Projects
None yet
Milestone
4.0 RC
Development

No branches or pull requests
1 participant
@emgarten