Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable nuget.exe pack for project.json by default, add a fallback env var to enable it #4243

Merged
merged 9 commits into from
Sep 29, 2021
Merged

Disable nuget.exe pack for project.json by default, add a fallback env var to enable it #4243

merged 9 commits into from
Sep 29, 2021

Conversation

nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Sep 2, 2021 •
edited
Loading

Bug

Fixes: NuGet/Home#11214
Fixes: NuGet/Home#9149

Regression? Last working version:

Description

Disable nuget.exe pack for project.json by default, add a fallback env var to enable it

See: NuGet/Home#7931 for more details.

PR Checklist

@nkolev92 nkolev92 requested a review from a team as a code owner September 2, 2021 23:55
@nkolev92 nkolev92 changed the title Disable nuget.exe pack for project.json by default, add a fallback env var to enable it. Disable nuget.exe pack for project.json by default, add a fallback env var to enable it Sep 2, 2021
@nkolev92 nkolev92 force-pushed the dev-nkolev92-obsoleteProjectJsonPack branch from b4c2392 to 104c69e Compare September 3, 2021 23:43
@ghost ghost added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 17, 2021
@ghost
Copy link

ghost commented Sep 17, 2021

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

@nkolev92
Copy link
Member Author

Hey @aortiz-msft

Hoping I can get an approval for this.

This is part of the long ongoing effort to reduce technical debt in nuget.exe.
project.json pack was a feature that never GA itself.
In an earlier triage meeting we agreed to turn off this feature behind a feature flag.

This change affects nuget.exe only.

@ghost ghost removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 20, 2021
@ghost ghost added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 27, 2021
@ghost
Copy link

ghost commented Sep 27, 2021

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

@nkolev92
Copy link
Member Author

Ready to be merged, rejected for 6.0, waiting for dev to be 6.1 to merge.

@ghost ghost removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 27, 2021
@nkolev92 nkolev92 merged commit b09707c into dev Sep 29, 2021
@nkolev92 nkolev92 deleted the dev-nkolev92-obsoleteProjectJsonPack branch September 29, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkan zivkan zivkan approved these changes

@erdembayar erdembayar erdembayar approved these changes

@jeffkl jeffkl jeffkl approved these changes

@dominoFire dominoFire Awaiting requested review from dominoFire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@nkolev92 @dominoFire @zivkan @erdembayar @jeffkl