Specify list size in TopologicalSortUtility.CalculateRelationships (#…

…5664)
NuGet · Mar 4, 2024 · 7cebd2c · 7cebd2c
1 parent 0d9fe5c
commit 7cebd2c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/NuGet.Core/NuGet.Packaging/TopologicalSortUtility.cs b/src/NuGet.Core/NuGet.Packaging/TopologicalSortUtility.cs
@@ -143,8 +143,9 @@ private static void CalculateRelationships(ItemDependencyInfo[] packages, Dictio
             {
                 var dependencies = package.DependencyIds ?? Array.Empty<string>();
 
-                foreach (var id in dependencies)
+                for (var i = 0; i < dependencies.Length; i++)
                 {
+                    var id = dependencies[i];
                     if (lookup.TryGetValue(id, out var dependencyPackage))
                     {
                         // Mark the current package as a parent
@@ -160,7 +161,7 @@ private static void CalculateRelationships(ItemDependencyInfo[] packages, Dictio
                         var packageChildren = package.Children;
                         if (packageChildren == null)
                         {
-                            packageChildren = new List<ItemDependencyInfo>();
+                            packageChildren = new List<ItemDependencyInfo>(dependencies.Length - i);
                             package.Children = packageChildren;
                         }
                         packageChildren.Add(dependencyPackage);