Disable pack determinism because of unforeseen impact on deployment t…

…ools (#3060)
NuGet · Sep 18, 2019 · 84230f1 · 84230f1
1 parent 5577b91
commit 84230f1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/PackageBuilder.cs b/src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/PackageBuilder.cs
@@ -91,7 +91,7 @@ public PackageBuilder()
         private PackageBuilder(bool includeEmptyDirectories, bool deterministic)
         {
             _includeEmptyDirectories = includeEmptyDirectories;
-            _deterministic = deterministic;
+            _deterministic = false; // fix in https://github.com/NuGet/Home/issues/8601
             Files = new Collection<IPackageFile>();
             DependencyGroups = new Collection<PackageDependencyGroup>();
             FrameworkReferences = new Collection<FrameworkAssemblyReference>();

diff --git a/test/NuGet.Clients.Tests/NuGet.CommandLine.Test/NuGetPackCommandTest.cs b/test/NuGet.Clients.Tests/NuGet.CommandLine.Test/NuGetPackCommandTest.cs
@@ -5970,7 +5970,7 @@ private static void VerifyNuspecRoundTrips(PackageArchiveReader nupkgReader, str
             }
         }
 
-        [Fact]
+        [Fact(Skip = "https://github.com/NuGet/Home/issues/8601")]
         public void PackCommand_Deterministic_MultiplePackInvocations_CreateIdenticalPackages()
         {
             var nugetexe = Util.GetNuGetExePath();

diff --git a/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/PackCommandTests.cs b/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/PackCommandTests.cs
@@ -3967,7 +3967,7 @@ public void PackCommand_WithGeneratePackageOnBuildSet_CanPublish()
             }
         }
 
-        [PlatformFact(Platform.Windows)]
+        [PlatformFact(Platform.Windows, Skip = "https://github.com/NuGet/Home/issues/8601")]
         public void PackCommand_Deterministic_MultiplePackInvocations_CreateIdenticalPackages()
         {
             using (var testDirectory = TestDirectory.Create())
-Original file line number
+Diff line change
@@ Expand Up @@
                 }
             }
-            [Fact]
+            [Fact(Skip = "https://github.com/NuGet/Home/issues/8601")]
             public void PackCommand_Deterministic_MultiplePackInvocations_CreateIdenticalPackages()
             {
                 var nugetexe = Util.GetNuGetExePath();
@@ Expand Down @@