Avoid creating the capture class for calls to WithExtension (#5552)

NuGet · Jan 8, 2024 · ac17919 · ac17919
1 parent 0139b89
commit ac17919
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/BuildAssetsUtils.cs b/src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/BuildAssetsUtils.cs
@@ -722,12 +722,24 @@ private static bool Exists(this Lazy<LocalPackageSourceInfo> package)
 
         private static IEnumerable<LockFileItem> WithExtension(this IList<LockFileItem> items, string extension)
         {
-            if (items == null)
+            if (items == null || items.Count == 0)
             {
                 return Enumerable.Empty<LockFileItem>();
             }
 
-            return items.Where(c => extension.Equals(Path.GetExtension(c.Path), StringComparison.OrdinalIgnoreCase));
+            return FilterExtensions(items, extension);
+
+            static IEnumerable<LockFileItem> FilterExtensions(IList<LockFileItem> items, string extension)
+            {
+                for (int i = 0; i < items.Count; ++i)
+                {
+                    var item = items[i];
+                    if (extension.Equals(Path.GetExtension(item.Path), StringComparison.OrdinalIgnoreCase))
+                    {
+                        yield return item;
+                    }
+                }
+            }
         }
 
         private static string GetMatchingFrameworkStrings(PackageSpec spec, NuGetFramework framework)