Skip to content

Commit

Permalink
Cleanup and get ready for review
Browse files Browse the repository at this point in the history
  • Loading branch information
nkolev92 committed Dec 17, 2024
1 parent 92661c8 commit efcb1e0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ internal static class SdkAnalysisLevelMinimums
internal static readonly NuGetVersion HttpErrorSdkAnalysisLevelMinimumValue = new("9.0.100");

/// <summary>
/// Minimum SDK Analysis Level required for warning for packages and projects that cnanot be pruned.
/// Minimum SDK Analysis Level required for warning for packages and projects that cannot be pruned.
/// </summary>
internal static readonly NuGetVersion PruningWarnings = new("10.0.100");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5257,8 +5257,6 @@ await SimpleTestPackageUtility.CreateFolderFeedV3Async(
installedPackages.Should().HaveCount(1);
}

// TODO NK - Multiple restores, potentially shared RemoteResolveItem and potentially shared LockFileTargetLibraryCache.

private static void CreateFakeProjectFile(PackageSpec project2spec)
{
Directory.CreateDirectory(Path.GetDirectoryName(project2spec.RestoreMetadata.ProjectUniqueName));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ public static TestRestoreRequest CreateRestoreRequest(SimpleTestPathContext path
new List<PackageSource> { new PackageSource(pathContext.PackageSource) };

var externalClosure = DependencyGraphSpecRequestProvider.GetExternalClosure(dgSpec, projectToRestore.RestoreMetadata.ProjectUniqueName).ToList();
// TODO NK - Ensure the closure matches the total number of ProjectReferences.

return new TestRestoreRequest(projectToRestore, sources, pathContext.UserPackagesFolder, logger)
{
Expand Down

0 comments on commit efcb1e0

Please sign in to comment.