Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing RID specific assets from compile #1103

Merged
merged 1 commit into from
Mar 1, 2017
Merged

Conversation

emgarten
Copy link
Member

@emgarten emgarten commented Jan 6, 2017

This change removes RID specific assets in the runtimes/ folder from the compile section of the assets file.

When referencing a package that contained only runtimes/ assets it was possible to fallback to using these assets under compile.

Previous behavior:

  1. Select compile assets from ref/
  2. If no ref/ assets exist try lib/ and runtimes/ assets.

Fixed behavior:

  1. Select compile assets from ref/
  2. If no ref/ assets exist try lib/ assets.

Risk

Users depending directly on runtime only packages and not the ref package could see build breaks when the compile assets are missing. In this scenario it seems like users should just fix their references.

Fixes NuGet/Home#4207

//cc @ericstj @alpaix @rrelyea

@emgarten
Copy link
Member Author

emgarten commented Jan 6, 2017

//cc @joelverhagen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuGet restore is selecting compile assets from runtime section.
3 participants