Improve NuGet.targets restore perf #1214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walk project to project references first while creating a minimum number of items to track the full closure of projects. Removing duplicates along the way is important for perf reasons, if too many items are created restore will grind to a halt as they build. Once all projects have been found create specs for the projects directly instead of creating them during the walk. This also helps to keep the number of items down. Performance improvement on a project with 127 projects with a maximum number of project references between them. Before: 900 seconds After: 21 seconds In addition to the perf changes this also adds in the full set of dotnet cli tool references when recursive is set. Getting this information is much easier now that the full set of projects is found up front. Fixes NuGet/Home#4592 Fixes NuGet/Home#4711
emgarten
requested review from
rohit21agrawal,
nkolev92,
zhili1208,
alpaix,
mishra14 and
jainaashish
rohit21agrawal
approved these changes
Mar 1, 2017
| @@ -47,6 +47,10 @@ public override bool Execute() | |||
|
|
|||
| var entries = new List<ITaskItem>(); | |||
|
|
|||
| // Filter obvious duplicates without considering OS case sensitivity. | |||
| // This will be filtered further when creating the spec. | |||
| var seen = new HashSet<string>(StringComparer.Ordinal); | |||
There was a problem hiding this comment.
why? why can't we use the right comparer based on OS here as well?
There was a problem hiding this comment.
It could use that check, but I think this is better handled at a higher level when creating the dg file. This part is just a helper in MSBuild that creates items with extra metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walk project to project references first while creating a minimum number of items to track the full closure of projects. Removing duplicates along the way is important for perf reasons, if too many items are created restore will grind to a halt as they build.
Once all projects have been found create specs for the projects directly instead of creating them during the walk. This also helps to keep the number of items down.
Performance improvement on a project with 127 projects with a maximum number of project references between them.
Before: 900 seconds
After: 21 seconds
In addition to the perf changes this also adds in the full set of dotnet cli tool references when recursive is set. Getting this information is much easier now that the full set of projects is found up front.
Single() -> First()changes in the tests are due to changes to the SDK. These tests fail to for me, but work fine on the CI today which uses an older build.Fixes NuGet/Home#4592
Fixes NuGet/Home#4711