Fix bug in the unique name generation for tools in the commandline clients #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion in the tool reference
nkolev92
requested review from
rohit21agrawal,
PatoBeltran,
emgarten,
zhili1208,
alpaix,
mishra14 and
jainaashish
emgarten
reviewed
Aug 8, 2017
| @@ -103,7 +103,7 @@ public override bool Execute() | |||
| BuildTasksUtility.CopyPropertyIfExists(msbuildItem, properties, "Version"); | |||
|
|
|||
| properties.TryGetValue("Version", out string value); | |||
| var uniqueName = ToolRestoreUtility.GetUniqueName(msbuildItem.ItemSpec, ToolFramework, VersionRange.Parse(value)); | |||
| var uniqueName = ToolRestoreUtility.GetUniqueName(msbuildItem.ItemSpec, ToolFramework, value != null ? VersionRange.Parse(value) : null); | |||
There was a problem hiding this comment.
any reason not to use VersionRange.All? does that get printed out in a strange way?
There was a problem hiding this comment.
That's a good point.
Refactoring it now.
emgarten
approved these changes
Aug 8, 2017
nkolev92
added a commit
that referenced
this pull request
Aug 8, 2017
…lients (#1627) * Handle case, during the unique name generation, where there is no version in the tool reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NuGet/Home#5716
Fix bug in the unique name generation for tools in the commandline clients
Align the tool restore experience when a version is not specified among VS and CLIs.