[WIP]add options to suppress dependencies and assembly references in packge #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit21agrawal
force-pushed
the
dev-ragrawal-suppressdependency
branch
from
f3858a3 to
3d5210b
Compare
|
see referenced issue for workaround |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#6354
Fix
Details: Adds two flags - one to suppress framewor assembly references, and other to suppress package dependencies. These can be framework specific based on msbuild conditions.
These flags are called:
SuppressAssemblyReferencesInPackageandSuppressDependenciesInPackageTesting/Validation
Tests Added: Writing tests