add options to suppress dependencies in package #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit21agrawal
force-pushed
the
dev-ragrawal-suppressdependency
branch
2 times, most recently
from
d088ce1 to
7967171
Compare
rohit21agrawal
requested review from
PatoBeltran,
nkolev92,
zhili1208,
mishra14,
dtivel and
jainaashish
|
🔔 |
jainaashish
reviewed
May 16, 2018
| @@ -45,6 +45,7 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| <ImportNuGetBuildTasksPackTargetsFromSdk Condition="'$(ImportNuGetBuildTasksPackTargetsFromSdk)' == ''">false</ImportNuGetBuildTasksPackTargetsFromSdk> | |||
| <AllowedOutputExtensionsInPackageBuildOutputFolder>.dll; .exe; .winmd; .json; .pri; .xml; $(AllowedOutputExtensionsInPackageBuildOutputFolder)</AllowedOutputExtensionsInPackageBuildOutputFolder> | |||
| <AllowedOutputExtensionsInSymbolsPackageBuildOutputFolder>.pdb; .mdb; $(AllowedOutputExtensionsInPackageBuildOutputFolder); $(AllowedOutputExtensionsInSymbolsPackageBuildOutputFolder)</AllowedOutputExtensionsInSymbolsPackageBuildOutputFolder> | |||
| <SuppressDependenciesOnPacking Condition="'$(SuppressDependenciesOnPacking)' == ''">false</SuppressDependenciesOnPacking> | |||
There was a problem hiding this comment.
nit: how about SuppressDependenciesOnPack instead of SuppressDependenciesOnPacking
jainaashish
reviewed
May 16, 2018
| @@ -205,11 +205,22 @@ public PackageBuilder GetPackageBuilder(IPackTaskRequest<IMSBuildItem> request) | |||
| .ToDictionary(msbuildItem => msbuildItem.Identity, | |||
| msbuildItem => msbuildItem.GetProperty("ProjectVersion"), PathUtility.GetStringComparerBasedOnOS()); | |||
| } | |||
| var nuGetFrameworkComparer = new NuGetFrameworkFullComparer(); | |||
| var frameworksWithSuppressedDependencies = new HashSet<NuGetFramework>(nuGetFrameworkComparer); | |||
| if (request.FrameworksWithSuppressedDependencies != null && request.FrameworksWithSuppressedDependencies.Any()) | |||
There was a problem hiding this comment.
FrameworksWithSuppressedDependencies is an array so you can use Length field instead of Any() which works on Enumerable interface even for a list or array
jainaashish
approved these changes
May 16, 2018
|
FYI I tested private build on SDK, works well https://github.com/dotnet/sdk/compare/release/2.1.4xx...wli3:try-private-build-supress-all-dependency?expand=1 |
nkolev92
approved these changes
May 21, 2018
rohit21agrawal
force-pushed
the
dev-ragrawal-suppressdependency
branch
from
7967171 to
7b0bc87
Compare
|
@rohit21agrawal do you know which version has this change? I still cannot find it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: NuGet/Home#6354
Introduces a new property called
SuppressDependenciesOnPackingthat allows you to suppress dependency for a particular framework, or all of them.You can condition this property for a target framework like you can any other property:
<SuppressDependenciesOnPacking Condition="'$(TargetFramework)'=='net46'>true</SuppressDependenciesOnPacking>CC: @wli3