fix : Restore does not generate lock file on NoOp #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heng-liu
requested review from
dominoFire,
nkolev92,
zivkan,
dtivel,
anangaur and
donnie-msft
nkolev92
requested changes
Apr 10, 2019
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/NoOpRestoreUtilities.cs
Outdated
Show resolved
Hide resolved
nkolev92
reviewed
Apr 15, 2019
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/NoOpRestoreUtilities.cs
Outdated
Show resolved
Hide resolved
nkolev92
approved these changes
Apr 16, 2019
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/NoOpRestoreUtilities.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/NoOpRestoreUtilities.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#7807
Regression: No
Fix
Details: Add validation of checking the existence of package lock file. If not, failed the no-op.
Testing/Validation
Tests Added: Yes
Reason for not adding tests:
Validation:
Note: the message of "Writing packages lock file at disk." will not be displayed by default if it's dotnet restore. But if add "-verbosity normal", then the message will show up.