Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for deprecation info to dotnet list package --outdated #2928

Merged
merged 23 commits into from
Jul 24, 2019
Merged

Add support for deprecation info to dotnet list package --outdated #2928

merged 23 commits into from
Jul 24, 2019

Conversation

xavierdecoster
Copy link
Member

Fixes NuGet/Home#8280

image

PR up for early review /cc @nkolev92 @rrelyea

@xavierdecoster xavierdecoster self-assigned this Jul 13, 2019
nkolev92
nkolev92 reviewed Jul 15, 2019
View reviewed changes
Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, I think maybe we can change the dependent resource to something more appropriate that will contain more of the required metadata.

It's crazy how many resources we have, lol.

...e/NuGet.CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/FrameworkPackages.cs Outdated Show resolved Hide resolved
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs Show resolved Hide resolved
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs Outdated Show resolved Hide resolved
src/NuGet.Core/NuGet.Protocol/Resources/MetadataResourceV3.cs Outdated Show resolved Hide resolved
src/NuGet.Core/NuGet.Protocol/Resources/MetadataResourceV3.cs Outdated Show resolved Hide resolved
zivkan
zivkan reviewed Jul 17, 2019
View reviewed changes
Copy link
Member

@zivkan zivkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the message should be changed because it currently says that the package was unlisted, but that's not the check the code makes.

...CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/InstalledPackageReference.cs Outdated Show resolved Hide resolved
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs Outdated Show resolved Hide resolved
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs Show resolved Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Utility/ProjectPackagesPrintUtility.cs Outdated Show resolved Hide resolved
nkolev92
nkolev92 approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

.../NuGet.CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommand.cs Outdated Show resolved Hide resolved
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs Outdated Show resolved Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Strings.resx Outdated Show resolved Hide resolved
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs Show resolved Hide resolved
@xavierdecoster xavierdecoster mentioned this pull request Jul 23, 2019
Open
@xavierdecoster
Copy link
Member Author

@nkolev92 is this good to merge?

nkolev92
nkolev92 approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge if the tests are good.

Nice job. 👏

@xavierdecoster xavierdecoster merged commit 3da3d9d into dev Jul 24, 2019
@xavierdecoster xavierdecoster deleted the dev-issue8280 branch July 24, 2019 13:22
@zkat zkat mentioned this pull request Aug 7, 2019
Closed
@anangaur anangaur mentioned this pull request Sep 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkan zivkan zivkan approved these changes

@nkolev92 nkolev92 nkolev92 approved these changes

@rrelyea rrelyea Awaiting requested review from rrelyea

@dtivel dtivel Awaiting requested review from dtivel

@anangaur anangaur Awaiting requested review from anangaur

@skofman1 skofman1 Awaiting requested review from skofman1

Assignees

@xavierdecoster xavierdecoster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for deprecation info to dotnet list package --outdated
4 participants
@xavierdecoster @nkolev92 @zivkan @anangaur