Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pack determinism because of unforeseen impact on deployment tools #3060

Merged
merged 2 commits into from
Sep 18, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public PackageBuilder()
private PackageBuilder(bool includeEmptyDirectories, bool deterministic)
{
_includeEmptyDirectories = includeEmptyDirectories;
_deterministic = deterministic;
_deterministic = false;
nkolev92 marked this conversation as resolved.
Show resolved Hide resolved
Files = new Collection<IPackageFile>();
DependencyGroups = new Collection<PackageDependencyGroup>();
FrameworkReferences = new Collection<FrameworkAssemblyReference>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5970,7 +5970,7 @@ private static void VerifyNuspecRoundTrips(PackageArchiveReader nupkgReader, str
}
}

[Fact]
[Fact(Skip = "https://github.com/NuGet/Home/issues/8601")]
public void PackCommand_Deterministic_MultiplePackInvocations_CreateIdenticalPackages()
{
var nugetexe = Util.GetNuGetExePath();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3967,7 +3967,7 @@ public void PackCommand_WithGeneratePackageOnBuildSet_CanPublish()
}
}

[PlatformFact(Platform.Windows)]
[PlatformFact(Platform.Windows, Skip = "https://github.com/NuGet/Home/issues/8601")]
public void PackCommand_Deterministic_MultiplePackInvocations_CreateIdenticalPackages()
{
using (var testDirectory = TestDirectory.Create())
Expand Down