-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Studio PackageReference partial restore, solution based up to date check #3391
Conversation
143fc16
to
c1f7f63
Compare
src/NuGet.Clients/NuGet.SolutionRestoreManager/ISolutionRestoreChecker.cs
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.SolutionRestoreManager/SolutionRestoreBuildHandler.cs
Show resolved
Hide resolved
🔔 I'll do a rebase to resolve the conflicts, but it won't change the meat of the work (it's not in solutionrestorejob). |
…ate check that's particular to VS and the fact that it's a long running process
c1f7f63
to
5ab36e3
Compare
Resolved the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After rushing through a review of this, I don't understand it super well, but at the same time I didn't see anything that's a real concern to me.
src/NuGet.Clients/NuGet.SolutionRestoreManager/ISolutionRestoreChecker.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.SolutionRestoreManager/ISolutionRestoreChecker.cs
Outdated
Show resolved
Hide resolved
🔔 @dominoFire @erdembayar I just realized that @srdjanjovcic was not on the requested review list so adding him. :) |
Bug
Fixes: NuGet/Home#9513
Regression: No
Fix
Details:
Design at NuGet/Home#9564. Recommended you read that before reviewing. Specifically the https://github.com/NuGet/Home/blob/dev-nkolev92-partialrestore/designs/VisualStudio-PartialRestoreOptimization.md#solutionuptodatechecker section.
Pulling up the project level no-op to a solution level one with a few additional assumptions.
Some numbers:
Improvements of 60%+ in the NuGet.sln.
I will do numbers on more solutions as time progresses, but I am confident that the numbers will be comparable. Especially for SDK based projects.
Testing/Validation
Tests Added: Yes
Reason for not adding tests:
Validation: