Write source to .nupkg.metadata on package install #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
reviewed
Dec 4, 2020
erdembayar
approved these changes
Dec 4, 2020
nkolev92
approved these changes
Dec 4, 2020
src/NuGet.Core/NuGet.Packaging/NupkgMetadata/NupkgMetadataFile.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging/NupkgMetadata/NupkgMetadataFileFormat.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging/NupkgMetadata/NupkgMetadataFileFormat.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#10354
Regression: No
Fix
Details:
NupkgMetadataFile, and increment file version.nupkg.metadatafile when package is installed to global packages folder..nupkg.metadatafile lists the "original" package source or the global package folder's path. If the solution package folder's.nupkg.metadatalists the GPF as the source, the customer can check the GPF folder's.nupkg.metadatafile for the original source.Testing/Validation
Tests Added: Yes
Reason for not adding tests:
Validation: