Make by default validation disabled on Linux, but enabled by default on Windows #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heng-liu
reviewed
Mar 31, 2021
| @@ -452,6 +452,10 @@ public override bool CanVerifySignedPackages(SignedPackageVerifierSettings verif | |||
| { | |||
| return false; | |||
| } | |||
| else if (RuntimeEnvironmentHelper.IsLinux || RuntimeEnvironmentHelper.IsMacOSX) | |||
There was a problem hiding this comment.
I have a question, are we going to disable verification on Linux only, or on both Linux and MacOS?
There was a problem hiding this comment.
@JonDouglas is trying to reach out Apple. If no answer then better than sorry we do for both.
dtivel
approved these changes
Mar 31, 2021
src/NuGet.Core/NuGet.CommandLine.XPlat/NuGet.CommandLine.XPlat.csproj
Outdated
Show resolved
Hide resolved
test/NuGet.Core.Tests/NuGet.Packaging.Test/PackageArchiveReaderTests.cs
Outdated
Show resolved
Hide resolved
|
This is a customer impacting feature. The issue should be moved to Home, so that the release notes tool will include it, and customers have an issue they can read for more details. |
zivkan
pushed a commit
that referenced
this pull request
Apr 1, 2021
This was referenced Apr 1, 2021
Closed
This was referenced Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#10713 https://github.com/NuGet/Client.Engineering/issues/880
I'll add more details later if we go ahead with this change.
Regression? Last working version: N/A
Description
Anticipating Mozilla going to drop Symantec certificate CA from their trusted database we need to release pre-empt mitigation.
More details please check NuGet/Announcements#56.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation