Ensure the namespaces filtering is respected in packages.config package installation/updates in PMC #4150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
force-pushed
the
dev-eryondon-NameSpacePackageConfig-InstallUpdatePMC
branch
from
4acc7a4 to
7409945
Compare
erdembayar
force-pushed
the
dev-eryondon-NameSpacePackageConfig-InstallUpdatePMC
branch
from
7409945 to
3a4223d
Compare
erdembayar
force-pushed
the
dev-eryondon-NameSpacePackageConfig-InstallUpdatePMC
branch
from
3a4223d to
072d6b8
Compare
nkolev92
approved these changes
Jul 16, 2021
test/NuGet.Tests.Apex/NuGet.Tests.Apex/Utility/CommonUtility.cs
Outdated
Show resolved
Hide resolved
| @@ -149,6 +154,17 @@ public static SimpleTestPackageContext CreatePackage(string packageName, string | |||
| return package; | |||
| } | |||
|
|
|||
| public static SimpleTestPackageContext CreateCustomPackage(string packageName, string packageVersion, string requestAdditionalContent) | |||
There was a problem hiding this comment.
nit: CustomPackage is not a super descriptive name. A better name would call out what it's compatible with.
There was a problem hiding this comment.
Refactored it and rename to CreateNetCorePackage.
test/NuGet.Tests.Apex/NuGet.Tests.Apex/NuGetEndToEndTests/NuGetConsoleTestCase.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Tests.Apex/NuGet.Tests.Apex/NuGetEndToEndTests/NuGetConsoleTestCase.cs
Show resolved
Hide resolved
erdembayar
deleted the
dev-eryondon-NameSpacePackageConfig-InstallUpdatePMC
branch
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11001
Regression? Last working version: N/A
Description
This change ensuring that the namespaces are respected during package installation in PMC. If there is same package Id exist in 2 repositories then it only request it from one it specified in namespace filter, previously we try to fetch from all possible repositories and install one from fastest which may not be what user really wanted.
This PR is continuation of #4140.
Please note: init.ps1 is might not respect package namespace filtering, because technically any powershell command could be inside it and it can do pretty much anything including direct downloading assets from web.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation