Use IBuildDependencyProjectReferencesService to read projects references for CPS based packages.config projects

[nkolev92]

Bug

Fixes: NuGet/Home#11162

Regression? Last working version:

Description

There's a restore time UI delay:

UIDelay: nuget.packagemanagement.visualstudio.dll!NuGet.PackageManagement.VisualStudio.VsCoreProjectSystemReferenceReader+d__

It happens when mixed solutions are used, ones that have PackageReference projects & legacy managed projects & native projects.

The walk that we run in

NuGet.Client/src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/ProjectServices/VsCoreProjectSystemReferenceReader.cs

Line 54 in c1a0597

var itemsFactory = ServiceLocator.GetInstance<IVsEnumHierarchyItemsFactory>();

is inefficient and in some cases, such as the native case, it might even trigger a design time build.

The fix is to use a CPS specific API which is free threaded.
Note that there's currently a bug with this API: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1374627, which is being fixed as we speak.

Second part of this UI delay will be fixed in NuGet/Home#11163.

cc @lifengl @davkean

PR Checklist

• PR has a meaningful title

• PR has a linked issue.

• Described changes

• Tests

  • Automated tests added
  • OR
  • Test exception - There's no functional changes, but unfortunately there are no tests for the overall scenario. Given that this is a VS only scenario, and we have seen a lot of APEX flakiness, I decided to instead a manual test. https://github.com/nkolev92/CpsReferencesReaderTest. It's really against what I think we should be doing, but I see this as a pragmatic solution at this point.
    Finally there's a bug, which means it'll be a while until we can add an E2E/Apex test: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1374627
  • OR
  • N/A

• Documentation

  • Documentation PR or issue filled
  • OR
  • N/A

[nkolev92]

@davkean

Can you please take another look? Thanks!

@NuGet/nuget-client I need a review from you as well.

[davkean]

Assuming that await null is fixed, this looks good.

[nkolev92]

@NuGet/nuget-client Can someone take a look please?🔔