Pack NuGet.Localization in RTM builds #4320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
approved these changes
Oct 22, 2021
donnie-msft
approved these changes
Oct 22, 2021
jebriede
approved these changes
Oct 22, 2021
nkolev92
approved these changes
Oct 22, 2021
nkolev92
reviewed
Oct 22, 2021
| @@ -32,7 +32,7 @@ | |||
| ============================================================ | |||
| --> | |||
|
|
|||
| <Target Name="MoveLocalizedFilesToLocalizedArtifacts" Condition="'$(BuildRTM)' == 'false' AND Exists($(LocalizationRootDirectory)) " BeforeTargets="GenerateNuspec"> | |||
| <Target Name="MoveLocalizedFilesToLocalizedArtifacts" Condition="Exists($(LocalizationRootDirectory)) " BeforeTargets="GenerateNuspec"> | |||
There was a problem hiding this comment.
Did you check we actually localize for RTM?
There was a problem hiding this comment.
Yes, the build pipeline doesn't condition the localize task on anything, so it will localize on both RTM and NonRTM builds:
NuGet.Client/eng/pipelines/templates/Build_and_UnitTest.yml
Lines 101 to 107 in d822a6f
I also checked the build artifacts to make sure that NuGet.Localization.{version}.nupkg is generated, and contains what appears to be the correct files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11328
Regression? LNo
Description
Pack NuGet.Localization in RTM builds
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation