Nuget.exe push needs a helpful error message for timeout #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| catch (TaskCanceledException ex) | ||
| { | ||
| string timeoutMessage = LocalizedResourceManager.GetString(nameof(NuGetResources.PushCommandTimeoutError)); | ||
| throw new AggregateException(ex, new Exception(timeoutMessage)); |
There was a problem hiding this comment.
I would expect this to throw a more specific exception type. This works because it is just caught and written out to the console?
There was a problem hiding this comment.
Yeah the console programs catch all exceptions and print out their message as an error. I used AggregateException so that the original TaskCanceledException can be preserved to show its message and optionally its callstack (with verbose output is turned on). And then I combined it with a generic Exception so that a custom message can be displayed.
But if the callstack of the original TaskCanceledException doesn't matter, I can just throw a new specific type of exception here.
In reply to: 58240759 [](ancestors = 58240759)
|
|
spadapet
force-pushed
the
spadapet/PushTimeoutError
branch
from
6fc1145 to
c2bb129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NuGet/Home#2199
In each of the command line projects, if "push" times out, then show a better error message. The TaskCanceledException message "A task was canceled." still shows, but then I appended more info about how to change the timeout.
@toddm @emgarten