Signing: more SDK initialization and enable opt-in on Linux #4720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
approved these changes
Jul 12, 2022
|
I can see |
|
@erdembayar, it was expected. An explanation is at its use site. |
erdembayar
approved these changes
Jul 12, 2022
heng-liu
reviewed
Jul 12, 2022
heng-liu
reviewed
Jul 12, 2022
heng-liu
reviewed
Jul 12, 2022
heng-liu
approved these changes
Jul 12, 2022
dtivel
added a commit
that referenced
this pull request
Jul 13, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11956
Regression? Last working version: Yes, this change introduced a regression on Linux in two scenarios.
Description
To localize X.509 trust store initialization to .NET SDK scenarios that require it, initialization must be performed in any .NET SDK code path where package extraction (and thus signature verification) may occur. This PR adds missed initialization for
dotnet add packageand NuGet SDK resolver code paths.In addition, signature verification is being disabled by default on Linux for .NET 6 SDK but will be enabled by default for .NET 7 SDK. Also, the verbosity level of log messages indicating which X.509 trust store will be used has been changed from verbose to informational, because in the
dotnet add packagescenario, verbose messages aren't displayed, informational messages are, and there's no obvious way for a user to increase verbosity level.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation