Don't allocate temporaries in FrameworkNameProvider.GetVersionString #5250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
previously approved these changes
Jun 19, 2023
nkolev92
previously approved these changes
Jun 19, 2023
drewnoakes
force-pushed
the
dev-drnoakes-1837332-framework-version-string-allocations
branch
from
2649cd4 to
998ccd3
Compare
nkolev92
previously approved these changes
Jun 21, 2023
Previously this would allocate a stack, enumerators, and a copy of the stack (for a call to Linq's `Reverse`). With this change all state required to produce the version string is kept on the stack. The unit test coverage for this method has been increased. Also the allocation of an empty `Version` was removed in the `Try*` methods when they return false, to make them match their signatures and avoid a wasted allocation. Consuming code in this repo has been reviewed, and the behaviour captured in unit tests.
drewnoakes
force-pushed
the
dev-drnoakes-1837332-framework-version-string-allocations
branch
from
998ccd3 to
d44c1b9
Compare
nkolev92
approved these changes
Jun 21, 2023
|
@jeffkl Rerequesting review from you. |
|
Jeff is out, enabling auto merge. |
nkolev92
deleted the
dev-drnoakes-1837332-framework-version-string-allocations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12685
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1837332
Regression? Last working version: N/A
Description
Previously
FrameworkNameProvider.GetVersionStringwould heap allocate aStack<int>, a few enumerators, and a copy of the stack (for a call to Linq'sReverse).With this change all state required to produce the version string is kept on the stack.
The unit test coverage for this method has been increased.
Also the allocation of an empty
Versionwas removed in theTry*methods when they return false, to make them match their signatures and avoid a wasted allocation. Consuming code in this repo has been reviewed, and the behaviour captured in unit tests.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation