Don't box enumerators in ContentItemCollection #5269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class has many foreach operations over interfaces such as IEnumerable, IList and IDictionary. We can avoid boxing these enumerators via the NoAllocEnumerate extension method. The allocation of these boxed enumerators was identified as a top contributor to GC pauses by GCPauseWatson.
nkolev92
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12689
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1837339
Regression? Last working version: N/A
Description
ContentItemCollectionhas manyforeachoperations over interfaces such asIEnumerable<>,IList<>andIDictionary<>. We can avoid boxing these enumerators via theNoAllocEnumerate()extension method.See #5246 for more information on that extension method.
The allocation of these boxed enumerators was identified as a top contributor to GC pauses by GCPauseWatson.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation