Remove allocations from PackageSource.Source setter #5271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `PackageSource.Source` property setter computes a hash code that includes string values in a case-insensitive way. It used to do that by allocating upper case strings, then computing the hashes on them. There's no need to allocate those temporary strings, as you can just use a `StringComparer` to compute the same value more efficiently. To remove these allocations I've delegated the hash code computation to `HashCodeCombiner`, which won't allocate (for ASCII strings, at least).
donnie-msft
approved these changes
Jun 23, 2023
nkolev92
approved these changes
Jun 23, 2023
nkolev92
deleted the
dev-drnoakes-1840739-PackageSource-SetSource-allocations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12692
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1840739
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1840740
Regression? Last working version:
Description
the
PackageSource.Sourceproperty setter computes a hash code that includes string values in a case-insensitive way. It used to do that by allocating upper case strings, then computing the hashes on them. There's no need to allocate those temporary strings, as you can just use aStringComparerto compute the same value more efficiently.To remove these allocations I've delegated the hash code computation to
HashCodeCombiner, which won't allocate (for ASCII strings, at least).PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation