DetectAndMarkAmbiguousCentralTransitiveDependencies should be exhaustive and deterministic #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive and deterministic
ghost
added
the
jeffkl
approved these changes
Jul 4, 2023
nkolev92
reviewed
Jul 6, 2023
src/NuGet.Core/NuGet.DependencyResolver.Core/GraphModel/GraphOperations.cs
Show resolved
Hide resolved
nkolev92
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12464
Regression? Last working version:
Description
The method
DetectAndMarkAmbiguousCentralTransitiveDependenciesdidn't anticipate that a parent of a central transitive node could also be a central transitive node. Thus the method relied on a particular order of central transitive nodes therefore it wasn't really correct. After this change, the order of central nodes doesn't matter anymore.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation