Null annotate PackageDependencyInfo #5311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a word to the spelling exclusion list.
nkolev92
reviewed
Jul 12, 2023
| { | ||
| get { return _dependencies; } | ||
| } | ||
| public IEnumerable<PackageDependency> Dependencies => _dependencies; |
There was a problem hiding this comment.
nit: This can just be a property correct? Or is there somewhere in the class where we use the fact that _dependencies is an array/
There was a problem hiding this comment.
Made it into an auto property.
nkolev92
approved these changes
Jul 13, 2023
|
@zivkan - Would you please take a look since you worked on the same on a different project? |
zivkan
approved these changes
Jul 19, 2023
|
I updated the checklist to comply with our contribution guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12763
Regression? no
Description
I had annotated this locally as part of some other work then realised I didn't need it for that. Rather than throw away that work, I'm pushing it here.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation