Add .vdproj to the exclusion list

[drolevar]

Bug

Fixes: NuGet/Home#7796

Description

The projects with .vdproj extension are legacy installer projects which are not MSBuild-compatible, and yet they are supported even by the latest Visual Studio 2022. Running "nuget restore" on solutions containing such projects fails, unless "inclusionlist" mode is chosen. However "inclusionlist" option prevents certain other projects (e.g. .wixproj) from being restored. The .vdproj projects always have to be excluded from restore.

PR Checklist

• PR has a meaningful title

• PR has a linked issue.

• Described changes

• Tests

  • Test exception

• Documentation

  • N/A

[drolevar]

@jeffkl Any idea why tests are failing? I don't have access to the logs. Or is where a different reason why it's not resolved?

[zivkan]

Apex tests are failing regularly for everyone due to some infrastrcture issue. Ignore it.

The windows func tests failed because the test host process crashes sometimes. I retried the CI job and it passed this time.

So, no test problems to worry about.

[drolevar]

@zivkan Ok. It's just the PR is still open, the commit isn't merged, and I'm not really sure why.

[jeffkl]

@drolevar We'll review this one more time as a team tomorrow and probably merge it. Thanks again for the contribution!

[prasadbob]

Hi guys, I'm still facing same issue with my pipeline while Nuget Restore, is there any way you guys can help me out?

Nuget version - 6.0.0.280

[zivkan]

@prasadbob if you follow the link to the merge commit, we can see that the git tag with the lowest version number is 6.8.0.65. No, no version of NuGet below 6.8 will have the change. Also, 6.8 isn't GA yet, so it's only available in preview versions of msbuild 17.8 and .NET 8

[prasadbob]

@zivkan , thanks for the quick reply, is there any way i can build my pipeline with nuget restore?

[zivkan]

you can use a solution filter that excludes the vdproj, and then restore the slnf istead.

[prasadbob]

I was able to exclude vdproj file using slnf file, but is there any way I can build vdproj file using MsBuild job on devops pipeline?

[zivkan]

I don't know, that's not a NuGet question. My guess would be (assuming you're using yaml pipelines):

- script: msbuild path\to\your.vdproj

Alternatively, only restore the solution filter, but then build the solution (not filter).

If that doesn't work, you'll need to seek other people who have experience with vdproj. Perhaps ask on stack overflow. This conversation has diverged significantly from the subject of this issue's title.

[drolevar]

I was able to exclude vdproj file using slnf file, but is there any way I can build vdproj file using MsBuild job on devops pipeline?

.vdproj cannot be built with MSBuild, and that's exactly the reason for this pull request. The way to build it as a part of a DevOps pipeline is to run devenv.com with the name of the project and corresponding parameters. Google it.