allow empty sb intermediate #5352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jeffkl
approved these changes
Aug 14, 2023
|
Can you please follow the PR template. Thanks! |
|
@oleksandr-didyk Can you do a rebase to the latest commit of dev? Sorry, we had a problem in our CI that is fixed now. Thanks! |
oleksandr-didyk
force-pushed
the
allow-empty-sb-intermediate
branch
from
d0ca55c to
fea917b
Compare
No problem, rebased |
My bad, should be fixed now |
nkolev92
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: dotnet/arcade#13126
Regression? Last working version:
Description
Resolves an issue with NuGet source-build intermediate originally found by dotnet/arcade#13067. This is achieved by introducing and empty intermediate check in source-build infra and allowing this repository to produce an empty intermediate until NuGet/Home#11059 is resolved.
.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation